Propagate DAGCircuit.name in ApplyLayout (backport #13910)#13920
Merged
jakelishman merged 1 commit intostable/1.4from Feb 25, 2025
Merged
Propagate DAGCircuit.name in ApplyLayout (backport #13910)#13920jakelishman merged 1 commit intostable/1.4from
DAGCircuit.name in ApplyLayout (backport #13910)#13920jakelishman merged 1 commit intostable/1.4from
Conversation
Contributor
Author
|
Cherry-pick of 29aa2bd has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
Bot
added
the
conflicts
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
Bot
added
Changelog: Fixed
jakelishman
force-pushed
the
mergify/bp/stable/1.4/pr-13910
branch
from
d11512f to
a87fa39
Compare
jakelishman
removed
the
conflicts
jakelishman
previously approved these changes
Feb 25, 2025
Pull Request Test Coverage Report for Build 13525152901Details
💛 - Coveralls |
* Propagate `DAGCircuit.name` in `ApplyLayout` This has always been absent, but `transpile` masked the problem by assigning the output circuit names by overwriting the `output_names` input kwarg if it wasn't set. `generate_preset_pass_manager` didn't have the same logic, so it was observable that `ApplyLayout` didn't propagate the name. We could have added similar name-propagation logic to `generate_preset_pass_manager`, but really the bug is in `ApplyLayout`; passes _should_ propagate the metadata. * Fix typo Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> * Remove redunant set --------- Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com> (cherry picked from commit 29aa2bd)
jakelishman
force-pushed
the
mergify/bp/stable/1.4/pr-13910
branch
from
a87fa39 to
0be1080
Compare
jakelishman
approved these changes
Feb 25, 2025
jakelishman
removed this pull request from the merge queue due to the queue being cleared
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has always been absent, but
transpilemasked the problem by assigning the output circuit names by overwriting theoutput_namesinput kwarg if it wasn't set.generate_preset_pass_managerdidn't have the same logic, so it was observable thatApplyLayoutdidn't propagate the name.We could have added similar name-propagation logic to
generate_preset_pass_manager, but really the bug is inApplyLayout; passes should propagate the metadata.Summary
Details and comments
This is an automatic backport of pull request #13910 done by [Mergify](https://mergify.com).